Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/iqama time message screen #1106

Merged
merged 5 commits into from
Apr 14, 2024
Merged

Conversation

ghassenbenzahra123
Copy link
Contributor

📝 Summary

This PR fixes #1029

Description

It adjusts the ui of salat items in the portrait mode and add the iqama time in all the subscreens.
Tests

🧪 Use case 1

💬 Description:

Launch the app and scroll through the different worflow screens & make sure to enable iqama is more important value from the backoffice. Make sure to test both turkey & normal mosques to observe the imsak salat item.

📷 Screenshots or GIFs (if applicable):

Screenshot_1712680444

Checklist:

  • Coding Standards: I have reviewed my code to ensure it follows the project's coding standards.
  • Testing: I have tested the changes and they work as expected.
  • Merge Conflicts: I have resolved any merge conflicts with the latest main/development branch.
  • Branch Status: The branch is up-to-date with the target branch (main/development).

@ghassenbenzahra123 ghassenbenzahra123 self-assigned this Apr 9, 2024
@ghassenbenzahra123 ghassenbenzahra123 linked an issue Apr 9, 2024 that may be closed by this pull request
@YassinNouh21
Copy link
Contributor

@ghassenbenzahra123 why did u add margin at the RandomHadithScreen and DuaaEftarScreen also

Copy link
Contributor

@YassinNouh21 YassinNouh21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghassenbenzahra123 ghassenbenzahra123 merged commit f4f4e97 into main Apr 14, 2024
1 check passed
@ghassenbenzahra123 ghassenbenzahra123 deleted the feat/iqama-time-message-screen branch April 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iqama time message screen
2 participants